Few adjustments to allow to use the server properly from the fronten… #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you prefer to throw a 500 error instead of 400? In this case, I think that it is a controlled error, and then maybe it is better to use 400. |
ebrehault
force-pushed
the
adapt-to-front
branch
from
4a2c1a3 to
50e3866
Compare
ebrehault
force-pushed
the
adapt-to-front
branch
from
d51809e to
6eced82
Compare
ebrehault
force-pushed
the
adapt-to-front
branch
from
6eced82 to
e65ef17
Compare
rboixaderg
reviewed
Dec 14, 2023
| @@ -28,10 +28,6 @@ export class CreateSyncDto { | |||
| if (!connectorDefinition) { | |||
| return ['Connector definition is not defined']; | |||
| } | |||
| const sourceConnector = connectorDefinition.factory(); | |||
There was a problem hiding this comment.
Is it possible to create a sync object without validate the conector data?
| constructor(private readonly repository: ISyncRepository) {} | ||
|
|
||
| async execute(id: string) { | ||
| const data = await this.repository.getSync(id); |
There was a problem hiding this comment.
You can create an SyncEntity and get the sourceConector from there to get the auth data. it Is better because we will have only one responsible to manage this, the entity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d app